github-widget
Dev tools
embeddable profile widget
SHOW HN2016
How HN took it
7 positive, 13 neutral or asking, 3 mixed, 2 critical, out of 25 comments about the project. Thread score +0.21.
Execution: 2 for, 1 againstDesign: 1 for, 0 againstIdea: 0 for, 1 against
The thread, comment by comment
Each row is a top-level comment and its replies, in HN's order. Select a cell to open that comment on HN.
positive neutral or mixed critical about another commenter or something else the maker
What HN said
What people liked
Clean, readable code for a beginner
From 2 comments
That's surprisingly readable for someone having coded less than a year. Granted, it's only about a 100 lines so not that much complexity, but still separated into smaller,…
maaaats on HNBrava! Very clean and thoughtful architecture, especially impressive given your short history with code, and that humbles me, an "old guy" compared to most of the readers here.…
spdustin on HN
Good work for someone learning to code
From 2 comments
As someone who is also learning to code and has been for about 18 months, great job :)
parr0t on HNNice project! Kudos for sticking to the learning bit -- being motivated without external forces is harder than most people think. Suggestion: you're getting a lot of good…
hndl on HN
Objections
Appends styles to the host page body, which can alter links
From 1 comment
Nice job! One suggestion from a person who developed widgets used on lots of sites: You are appending general styles (like styling the a tag, ".container" which is a popular…
lepunk on HN
Possible XSS from inserting GitHub profile fields as HTML
From 1 comment
Cool! If you're not 100% sure that the GitHub data fields (bio, name, etc) are stripped of markup, please ensure that your widget isn't vulnerable to cross-site scripting (XSS).…
mbrock on HN
Repeated jQuery selectors and appends hurt performance
From 2 comments
Small tip to get some more performance; never repeat your selectors. If you need $(".stats") four times, don't repeat that four times, but do: ``` var stats = $('.stats') ``` and…
NKCSS on HNGood stuff. Tip: Rather than repeating .append several times, concatenate your result in a variable, then at the end append the complete result. That way you just make one append…
pacomerh on HN
Shows wrong top repositories for some users
From 1 comment
Nice! note: I haven't filed it as bug yet, as I am unsure about the reason yet. But when I user data-username="gbraad" I do not see the correct Top repositories. At the top…
gbraad on HN
Requests
Remove jQuery dependency
From 1 comment
Next task (upping the skill level): Remove jQuery as a dependancy.
wassago on HN
Use EsLint and underscore templating
From 1 comment
Looks cool. Couple of pointers: - Use a tool like EsLint to lint your code. It will make it more readable and cleaner than it is right now. Maybe integrate your editor with…
mundanevoice on HN
Show 'today' instead of 'Last active 0 days ago'
From 1 comment
Small note: "Last active 0 days ago" would be nice to be written as "today" :)
Ichaelus on HN
Questions
What is the alternative to jQuery here?
From 1 comment
what is the alternative in this case?
akagetsu01 on HN
What security practices should widget makers follow?
From 1 comment
Well done! It would be very handy to know what is a 'must have list' when implementing those kind of widgets, does anyone came across anything like this? I mean what I shall be…
LukaszB on HN
Alternatives named
github-cards by lepture
From 1 comment
Lepture have created a similar one before: https://github.com/lepture/github-cards
kxxoling on HN
gh-events-widget by todvora
From 1 comment
GitHub API and JSONP support is a nice way, how to play with those data in browsers. I wanted to have a GitHub timeline on my personal website, instead of the Twitter timeline.…
tdvorak on HN