cryptocompare
Languages and libraries
haskell library
SHOW HN2017
86points
17comments
#528of 2,242 in 2017
Top 24%of 2017 by points
How HN took it
CuriousMostly questions and neutral comments
1 positive, 3 neutral or asking, 0 mixed, 2 critical, out of 6 comments about the project. Thread score 0.00.
Execution: 1 for, 1 againstDocs: 0 for, 1 against
The thread, comment by comment
Each row is a top-level comment and its replies, in HN's order. Select a cell to open that comment on HN.
positive neutral or mixed critical about another commenter or something else the maker
What HN said
What people liked
Clean, readable Haskell code
From 1 comment
Clear, readable value-level Haskell is an underappreciated joy. What are you using this for, if anything?
mrkgnao on HN
Objections
Title is misleading since it does no pricing itself and only wraps a public API
From 1 comment
Title might confuse the audience since this doesn’t do any pricing per se, and only wraps a public API
arthurcolle on HN
Code could be improved: use Text, readMaybe instead of read, enums for sort orders
From 2 comments
* Consider using `Text` instead of `String`, as `String` is a linked-list of `Char` and quite inefficient * Consider refining some of your fields into more constrained types.…
endgame on HNI don't have it in front of me but I would assume the FromJSON instance for Float expects a JSON number, not a string. If the remote API makes the (puzzling) decision to put…
thinkpad20 on HN
API returns numeric values as strings, which is odd
From 2 comments
I don't have it in front of me but I would assume the FromJSON instance for Float expects a JSON number, not a string. If the remote API makes the (puzzling) decision to put…
thinkpad20 on HNWhat a bizarre API. You might get some mileage out of writing a helper function like `readParser :: Read a => String -> Parser a` which can call `readMaybe` and inspect the result.
endgame on HN
Requests
Code review and suggestions
From 1 comment
Feedback is welcome! I wrote this library for my own use, but I'm happy to hear any suggestions, code improvements, etc
aviaviavi on HN
Questions
What the library is used for
From 1 comment
Clear, readable value-level Haskell is an underappreciated joy. What are you using this for, if anything?
mrkgnao on HN
Alternatives named
coinmarketcapr, an R package wrapping a similar API
From 1 comment
Self Plug: wrote a similar one for R as an R package https://github.com/amrrs/coinmarketcapr
amrrs on HN